Messages in this thread | | | Date | Tue, 9 Jun 2020 18:45:33 +0200 | From | Sebastian Reichel <> | Subject | Re: [PATCH 2/3] platform/x86: dell-wmi: add new keymap type 0x0012 |
| |
Hi,
On Tue, Jun 09, 2020 at 05:49:38PM +0200, Pali Rohár wrote: > On Monday 08 June 2020 20:36:58 Mario.Limonciello@dell.com wrote: > > Can you please comment here how you would like to see events like this should come > > through to userspace? > > > > * Wrong power adapter (you have X and should have Y) > > * You have plugged a dock into the wrong port > > * Fn-lock mode > > In my opinion, Fn-lock mode is related to input subsystem and should be > probably reported via input device. For a user, fn-lock is similar like > caps-lock, scroll-lock or num-lock. Also fn-lock is provided by other > laptops and therefore I would expect that kernel provide fn-lock state > for all laptops (thinkpad / latitude / ...) via same interface. And not > via dell-specific interface or general-vendor-message interface. > > Wrong power adapter sounds like something related to power subsystem. > Adding Sebastian to the loop, maybe he can provide some useful ideas > about it.
I'm missing a bit of context. I suppose this is about connecting a non-genuine power adapter rejected by the embedded controller? Support for that should be hooked into 'drivers/acpi/ac.c' (note: so far there is no standard power-supply class property for this). Also printing a warning to dmesg seems sensible.
-- Sebastian
> And plugged dock into wrong port. This is probably dell-specific event > and some interface for "vendor" messages from kernel to userspace would > be needed to deliver such things. [unhandled content-type:application/pgp-signature] | |