Messages in this thread | | | From | "Stankiewicz, Piotr" <> | Subject | RE: [PATCH v3 03/15] PCI: Use PCI_IRQ_MSI_TYPES where appropriate | Date | Tue, 9 Jun 2020 16:31:29 +0000 |
| |
> -----Original Message----- > From: Christoph Hellwig <hch@infradead.org> > Sent: Tuesday, June 9, 2020 5:51 PM > > On Tue, Jun 09, 2020 at 11:16:46AM +0200, Piotr Stankiewicz wrote: > > Seeing as there is shorthand available to use when asking for any type > > of interrupt, or any type of message signalled interrupt, leverage it. > > > > Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com> > > Reviewed-by: Logan Gunthorpe <logang@deltatee.com> > > The patch actually adding PCI_IRQ_MSI_TYPES still didn't show up on linux-pci. >
I'm not sure why it didn't get delivered. I just resent it, for sake of completeness.
> But from the person who added PCI_IRQ_*: > > NAK to the whole concept of PCI_IRQ_MSI_TYPES, I think this just makes the > code a lot more confusing. Especially with the new IMS interrupt type, which > really is a MSI-like interrupt but certainly shouldn't be added to this mask.
| |