Messages in this thread | | | Date | Tue, 9 Jun 2020 08:40:36 -0700 | From | Kees Cook <> | Subject | Re: [PATCH] sysctl: Delete the code of sys_sysctl |
| |
On Tue, Jun 09, 2020 at 02:20:05PM +0800, Xiaoming Ni wrote: > Since the commit 61a47c1ad3a4dc ("sysctl: Remove the sysctl system call"), > sys_sysctl has lost its actual role: any input can only return an error. > > Delete the code and return -ENOSYS directly at the function entry > > Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
Looks right to me.
Reviewed-by: Kees Cook <keescook@chromium.org>
Should this be taken a step further and just remove the syscall entirely and update the per-arch tables with the ENOSYS hole?
-Kees
-- Kees Cook
| |