lkml.org 
[lkml]   [2020]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 2/8] firmware: add offset to request_firmware_into_buf
On Fri, Jun 05, 2020 at 10:04:52PM -0700, Scott Branden wrote:
> static struct fw_priv *__allocate_fw_priv(const char *fw_name,
> struct firmware_cache *fwc,
> - void *dbuf, size_t size)
> + void *dbuf, size_t size,
> + size_t offset,
> + enum kernel_pread_opt opt)
> {

Your types are screwed up. size_t is the size of something in memory.
loff_t is an offset in a file. This should be an loff_t. One of the
other patches has the opposite problem.

(this is kind of a minor problem compared to all the complexity
problems, but it's worth mentioning)

\
 
 \ /
  Last update: 2020-06-09 16:35    [W:0.094 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site