lkml.org 
[lkml]   [2020]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 07/15] drm/amdgpu: Use PCI_IRQ_MSI_TYPES where appropriate
    Date
    Seeing as there is shorthand available to use when asking for any type
    of interrupt, or any type of message signalled interrupt, leverage it.

    Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com>
    Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
    ---
    drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 11 +----------
    1 file changed, 1 insertion(+), 10 deletions(-)

    diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
    index 0cc4c67f95f7..97141aa81f32 100644
    --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
    +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
    @@ -248,17 +248,8 @@ int amdgpu_irq_init(struct amdgpu_device *adev)
    adev->irq.msi_enabled = false;

    if (amdgpu_msi_ok(adev)) {
    - int nvec = pci_msix_vec_count(adev->pdev);
    - unsigned int flags;
    -
    - if (nvec <= 0) {
    - flags = PCI_IRQ_MSI;
    - } else {
    - flags = PCI_IRQ_MSI | PCI_IRQ_MSIX;
    - }
    /* we only need one vector */
    - nvec = pci_alloc_irq_vectors(adev->pdev, 1, 1, flags);
    - if (nvec > 0) {
    + if (pci_alloc_irq_vectors(adev->pdev, 1, 1, PCI_IRQ_MSI_TYPES) > 0) {
    adev->irq.msi_enabled = true;
    dev_dbg(adev->dev, "using MSI/MSI-X.\n");
    }
    --
    2.17.2
    \
     
     \ /
      Last update: 2020-06-09 11:18    [W:5.247 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site