Messages in this thread | | | From | Joonsoo Kim <> | Date | Wed, 10 Jun 2020 12:11:35 +0900 | Subject | Re: [PATCH v2 05/12] mm/hugetlb: unify hugetlb migration callback function |
| |
2020년 6월 9일 (화) 오후 10:43, Michal Hocko <mhocko@kernel.org>님이 작성: > > On Wed 27-05-20 15:44:56, Joonsoo Kim wrote: > [...] > > -/* page migration callback function */ > > struct page *alloc_huge_page_nodemask(struct hstate *h, > > struct alloc_control *ac) > > { > > ac->gfp_mask |= htlb_alloc_mask(h); > > + if (ac->nid == NUMA_NO_NODE) > > + ac->gfp_mask &= ~__GFP_THISNODE; > > Is this really needed? alloc_huge_page_node is currently only called > from numa migration code and the target node should be always defined.
Thanks! When I read the code, I was not sure that the target node is always defined so I left this code. However, if it's true, this code isn't needed at all. I will consider your suggestion in the next version.
Thanks.
| |