lkml.org 
[lkml]   [2020]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/4] dt-bindings: soc: brcm: add BCM63xx power domain binding
    From
    Date


    On 6/9/2020 3:52 AM, Álvaro Fernández Rojas wrote:
    > BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller
    > to enable/disable certain components in order to save power.
    >
    > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
    > ---
    > .../devicetree/bindings/mips/brcm/soc.txt | 17 +++++++++++++++++

    You should probably create a YAML binding from the beginning that way
    you get validation for free. This file should ultimately be broken down
    into separate YAML bindings, but I Have not had the time to do that yet
    (you are welcome to if you feel like it).

    Other than that, the binding definition looks good to me.
    --
    Florian

    \
     
     \ /
      Last update: 2020-06-10 03:16    [W:4.038 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site