Messages in this thread | | | Date | Wed, 10 Jun 2020 08:25:58 +0800 | From | kernel test robot <> | Subject | Re: [PATCH] iommu/arm-smmu: Don't bypass pinned stream mappings |
| |
Hi Jordan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on iommu/next] [also build test ERROR on v5.7 next-20200609] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Jordan-Crouse/iommu-arm-smmu-Don-t-bypass-pinned-stream-mappings/20200610-020733 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next config: x86_64-allyesconfig (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project bc2b70982be8f5250cd0082a7190f8b417bd4dfe) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/iommu/arm-smmu.c:1143:45: error: no member named 'pinned' in 'struct arm_smmu_s2cr' if (type == S2CR_TYPE_BYPASS && s2cr[idx].pinned) ~~~~~~~~~ ^ 1 error generated.
vim +1143 drivers/iommu/arm-smmu.c
1122 1123 static int arm_smmu_domain_add_master(struct arm_smmu_domain *smmu_domain, 1124 struct arm_smmu_master_cfg *cfg, 1125 struct iommu_fwspec *fwspec) 1126 { 1127 struct arm_smmu_device *smmu = smmu_domain->smmu; 1128 struct arm_smmu_s2cr *s2cr = smmu->s2crs; 1129 u8 cbndx = smmu_domain->cfg.cbndx; 1130 enum arm_smmu_s2cr_type type; 1131 int i, idx; 1132 1133 if (smmu_domain->stage == ARM_SMMU_DOMAIN_BYPASS) 1134 type = S2CR_TYPE_BYPASS; 1135 else 1136 type = S2CR_TYPE_TRANS; 1137 1138 for_each_cfg_sme(cfg, fwspec, i, idx) { 1139 if (type == s2cr[idx].type && cbndx == s2cr[idx].cbndx) 1140 continue; 1141 1142 /* Don't bypasss pinned streams; leave them as they are */ > 1143 if (type == S2CR_TYPE_BYPASS && s2cr[idx].pinned) 1144 continue; 1145 1146 s2cr[idx].type = type; 1147 s2cr[idx].privcfg = S2CR_PRIVCFG_DEFAULT; 1148 s2cr[idx].cbndx = cbndx; 1149 arm_smmu_write_s2cr(smmu, idx); 1150 } 1151 return 0; 1152 } 1153
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |