lkml.org 
[lkml]   [2020]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 19/36] devinet: fix memleak in inetdev_init()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit 1b49cd71b52403822731dc9f283185d1da355f97 ]

    When devinet_sysctl_register() failed, the memory allocated
    in neigh_parms_alloc() should be freed.

    Fixes: 20e61da7ffcf ("ipv4: fail early when creating netdev named all or default")
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ipv4/devinet.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/ipv4/devinet.c
    +++ b/net/ipv4/devinet.c
    @@ -262,6 +262,7 @@ static struct in_device *inetdev_init(st
    err = devinet_sysctl_register(in_dev);
    if (err) {
    in_dev->dead = 1;
    + neigh_parms_release(&arp_tbl, in_dev->arp_parms);
    in_dev_put(in_dev);
    in_dev = NULL;
    goto out;

    \
     
     \ /
      Last update: 2020-06-09 20:23    [W:4.276 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site