lkml.org 
[lkml]   [2020]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 26/46] NFC: st21nfca: add missed kfree_skb() in an error path
    Date
    From: Chuhong Yuan <hslester96@gmail.com>

    [ Upstream commit 3decabdc714ca56c944f4669b4cdec5c2c1cea23 ]

    st21nfca_tm_send_atr_res() misses to call kfree_skb() in an error path.
    Add the missed function call to fix it.

    Fixes: 1892bf844ea0 ("NFC: st21nfca: Adding P2P support to st21nfca in Initiator & Target mode")
    Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/nfc/st21nfca/dep.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/nfc/st21nfca/dep.c
    +++ b/drivers/nfc/st21nfca/dep.c
    @@ -184,8 +184,10 @@ static int st21nfca_tm_send_atr_res(stru
    memcpy(atr_res->gbi, atr_req->gbi, gb_len);
    r = nfc_set_remote_general_bytes(hdev->ndev, atr_res->gbi,
    gb_len);
    - if (r < 0)
    + if (r < 0) {
    + kfree_skb(skb);
    return r;
    + }
    }

    info->dep_info.curr_nfc_dep_pni = 0;

    \
     
     \ /
      Last update: 2020-06-09 20:14    [W:3.183 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site