lkml.org 
[lkml]   [2020]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 12/61] selinux: convert WARN_ONCE() to printk() in selinux_nlmsg_perm()
    3.16.85-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Richard Guy Briggs <rgb@redhat.com>

    commit d950f84c1c6658faec2ecbf5b09f7e7191953394 upstream.

    Convert WARN_ONCE() to printk() in selinux_nlmsg_perm().

    After conversion from audit_log() in commit e173fb26, WARN_ONCE() was
    deemed too alarmist, so switch it to printk().

    Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
    [PM: Changed to printk(WARNING) so we catch all of the different
    invalid netlink messages. In Richard's defense, he brought this
    point up earlier, but I didn't understand his point at the time.]
    Signed-off-by: Paul Moore <pmoore@redhat.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    security/selinux/hooks.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    --- a/security/selinux/hooks.c
    +++ b/security/selinux/hooks.c
    @@ -4683,9 +4683,10 @@ static int selinux_nlmsg_perm(struct soc
    err = selinux_nlmsg_lookup(sksec->sclass, nlh->nlmsg_type, &perm);
    if (err) {
    if (err == -EINVAL) {
    - WARN_ONCE(1, "selinux_nlmsg_perm: unrecognized netlink message:"
    - " protocol=%hu nlmsg_type=%hu sclass=%hu\n",
    - sk->sk_protocol, nlh->nlmsg_type, sksec->sclass);
    + printk(KERN_WARNING
    + "SELinux: unrecognized netlink message:"
    + " protocol=%hu nlmsg_type=%hu sclass=%hu\n",
    + sk->sk_protocol, nlh->nlmsg_type, sksec->sclass);
    if (!selinux_enforcing || security_get_allow_unknown())
    err = 0;
    }
    \
     
     \ /
      Last update: 2020-06-09 20:13    [W:4.268 / U:1.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site