Messages in this thread Patch in this message | | | From | Ben Hutchings <> | Date | Tue, 09 Jun 2020 19:03:59 +0100 | Subject | [PATCH 3.16 08/61] net-sysfs: fix netdev_queue_add_kobject() breakage |
| |
3.16.85-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: Eric Dumazet <edumazet@google.com>
commit 48a322b6f9965b2f1e4ce81af972f0e287b07ed0 upstream.
kobject_put() should only be called in error path.
Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Jouni Hogander <jouni.hogander@unikie.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Ben Hutchings <ben@decadent.org.uk> --- net/core/net-sysfs.c | 1 + 1 file changed, 1 insertion(+)
--- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -1158,6 +1158,7 @@ static int netdev_queue_add_kobject(stru #endif kobject_uevent(kobj, KOBJ_ADD); + return 0; err: kobject_put(kobj);
| |