lkml.org 
[lkml]   [2020]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.7 152/274] net: lpc-enet: fix error return code in lpc_mii_init()
    Date
    From: Wei Yongjun <weiyongjun1@huawei.com>

    [ Upstream commit 88ec7cb22ddde725ed4ce15991f0bd9dd817fd85 ]

    Fix to return a negative error code from the error handling
    case instead of 0, as done elsewhere in this function.

    Fixes: b7370112f519 ("lpc32xx: Added ethernet driver")
    Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
    Acked-by: Vladimir Zapolskiy <vz@mleia.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/nxp/lpc_eth.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
    index d20cf03a3ea0..311454d9b0bc 100644
    --- a/drivers/net/ethernet/nxp/lpc_eth.c
    +++ b/drivers/net/ethernet/nxp/lpc_eth.c
    @@ -823,7 +823,8 @@ static int lpc_mii_init(struct netdata_local *pldat)
    if (err)
    goto err_out_unregister_bus;

    - if (lpc_mii_probe(pldat->ndev) != 0)
    + err = lpc_mii_probe(pldat->ndev);
    + if (err)
    goto err_out_unregister_bus;

    return 0;
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-09 01:10    [W:2.465 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site