lkml.org 
[lkml]   [2020]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.7 136/274] media: m88ds3103: error in set_frontend is swallowed and not reported
    Date
    From: Sean Young <sean@mess.org>

    [ Upstream commit c4ed27cfed45c16c2dd16c9fa3b883e306177e40 ]

    Bail out if registers can not be updated.

    Addresses-Coverity-ID: 1461655 ("Code maintainability issues")

    Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
    Fixes: e6089feca460 ("media: m88ds3103: Add support for ds3103b demod")
    Signed-off-by: Sean Young <sean@mess.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/dvb-frontends/m88ds3103.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c
    index d2c28dcf6b42..abddab02db9e 100644
    --- a/drivers/media/dvb-frontends/m88ds3103.c
    +++ b/drivers/media/dvb-frontends/m88ds3103.c
    @@ -980,6 +980,8 @@ static int m88ds3103_set_frontend(struct dvb_frontend *fe)
    goto err;

    ret = m88ds3103_update_bits(dev, 0xc9, 0x08, 0x08);
    + if (ret)
    + goto err;
    }

    dev_dbg(&client->dev, "carrier offset=%d\n",
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-09 01:10    [W:4.253 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site