lkml.org 
[lkml]   [2020]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86/xen: Fix a -Wmissing prototypes warning for xen_start_kernel()
From
Date
On 6/6/20 10:27 AM, Benjamin Thiel wrote:
> Fix:
>
> arch/x86/xen/enlighten_pv.c:1212:34:
> warning: no previous prototype for ‘xen_start_kernel’ [-Wmissing-prototypes]
> asmlinkage __visible void __init xen_start_kernel(void)
>
> Add a prototype for xen_start_kernel() in a separate xen-specific header.


TBH I am not sure it's worth a new header file for a routine that is
only called from assembly (and never returns). I'd just add the
prototype right above function definition, with a comment describing
why. I see a few examples of this in the tree. Or maybe we even have an
attribute for this case?


(I also suspect the same may be needed for xen_prepare_pvh() BTW).


-boris


\
 
 \ /
  Last update: 2020-06-08 21:31    [W:1.152 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site