Messages in this thread | | | Date | Mon, 8 Jun 2020 20:25:24 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v1 3/6] mfd: core: Propagate software node group to the sub devices |
| |
On Mon, 08 Jun 2020, Andy Shevchenko wrote:
> From: Heikki Krogerus <heikki.krogerus@linux.intel.com> > > When ever device properties are supplied for a sub device, a software node > (fwnode) is actually created and then associated with that device. By allowing > the drivers to supply the complete software node group instead of just the > properties in it, the drivers can take advantage of the other features the > software nodes have on top of supplying the device properties. > > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/mfd/mfd-core.c | 31 +++++++++++++++++++++++++++---- > include/linux/mfd/core.h | 3 +++ > 2 files changed, 30 insertions(+), 4 deletions(-)
I'm not sure a change to the API is justified presently (same does go for 'properties' really, but as it was only a couple of lines, it didn't seem too intrusive).
My recommendation is to handle this in-house (i.e. locally in-driver) for now. When (if) more users adopt the practice, then we should consider to draw down on line numbers and repetition and make it part of the API.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |