Messages in this thread | | | Date | Mon, 8 Jun 2020 10:26:25 +0300 | From | Dan Carpenter <> | Subject | Re: Forest Bond <>,Greg Kroah-Hartman <>,, |
| |
On Sun, Jun 07, 2020 at 10:41:56PM +0000, Rodolfo C. Villordo wrote: > /* RTSRrvTime */ > - uRrvTime = uRTSTime + uCTSTime + uAckTime + uDataTime + 3 * pDevice->uSIFS; > + uRrvTime = uRTSTime + uCTSTime + uAckTime + uDataTime > + + 3 * pDevice->uSIFS;
The + character should go on the first line:
uRrvTime = uRTSTime + uCTSTime + uAckTime + uDataTime + 3 * pDevice->uSIFS;
The second line should be indented with:
[tab][tab][space][space][space]3 * pDevice->uSIFS;
Same rules apply everywhere. I'm not going to comment on every line.
> case RTSDUR_BA_F0: /* RTSDuration_ba_f0 */ > - uCTSTime = bb_get_frame_time(pDevice->byPreambleType, byPktType, 14, pDevice->byTopCCKBasicRate); > - if ((byFBOption == AUTO_FB_0) && (wRate >= RATE_18M) && (wRate <= RATE_54M)) > + uCTSTime = bb_get_frame_time(pDevice->byPreambleType, byPktType, > + 14, pDevice->byTopCCKBasicRate); > + if ((byFBOption == AUTO_FB_0) && (wRate >= RATE_18M) && > + (wRate <= RATE_54M))
Here it's awkward to break the two wRate conditions across multiple lines. It's better to write:
if ((byFBOption == AUTO_FB_0) && (wRate >= RATE_18M) && (wRate <= RATE_54M))
regards, dan carpenter
| |