Messages in this thread | | | Subject | Re: [PATCH] staging: kpc2000: kpc_dma: Convert get_user_pages() --> pin_user_pages() | From | John Hubbard <> | Date | Mon, 8 Jun 2020 12:05:57 -0700 |
| |
On 2020-06-08 12:01, Souptick Joarder wrote: > On Mon, Jun 1, 2020 at 7:15 AM John Hubbard <jhubbard@nvidia.com> wrote: >> >> On 2020-05-31 10:51, Souptick Joarder wrote: >>> In 2019, we introduced pin_user_pages*() and now we are converting >>> get_user_pages*() to the new API as appropriate. [1] & [2] could >>> be referred for more information. >>> >>> When pin_user_pages() returns numbers of partially mapped pages, >>> those pages were not unpinned as part of error handling. Fixed >>> it as part of this patch. >>> >> >> Hi Souptick, >> >> btw, Bharath (+cc) attempted to do the "put" side of this, last year. >> That got as far as a v4 patch [1], and then I asked him to let me put >> it into my tree. But then it didn't directly apply anymore after the >> whole design moved to pin+unpin, and so here we are now. >> >> >> If Bharath is still doing kernel work, you might offer him a Co-Developed-by: >> tag (see https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html). > > Sure, will add him as *Co-Developed-by* >>
Yes, but it's best to wait and see if he responds, before adding that tag, because it also required a Signed-off-by from him.
thanks, -- John Hubbard NVIDIA
| |