Messages in this thread | | | Date | Mon, 8 Jun 2020 08:52:43 -0700 | From | Matthew Wilcox <> | Subject | Re: [PATCH] exfat: Fix use after free in exfat_load_upcase_table() |
| |
On Mon, Jun 08, 2020 at 05:07:33PM +0200, Markus Elfring wrote: > > This code calls brelse(bh) and then dereferences "bh" on the next line > > resulting in a possible use after free. > > There is an unfortunate function call sequence. > > > > The brelse() should just be moved down a line. > > How do you think about a wording variant like the following? > > Thus move a call of the function “brelse” one line down. > > > Would you like to omit a word from the patch subject so that > a typo will be avoided there?
Markus, please go away. This comment is entirely unhelpful.
| |