lkml.org 
[lkml]   [2020]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] sunrpc: use kmemdup_nul() in gssp_stringify()
Thanks, applied.--b.

On Fri, May 08, 2020 at 08:40:00PM +0800, Chen Zhou wrote:
> It is more efficient to use kmemdup_nul() if the size is known exactly
> .
>
> According to doc:
> "Note: Use kmemdup_nul() instead if the size is known exactly."
>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> net/sunrpc/auth_gss/gss_rpc_upcall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/auth_gss/gss_rpc_upcall.c b/net/sunrpc/auth_gss/gss_rpc_upcall.c
> index 0349f455a862..af9c7f43859c 100644
> --- a/net/sunrpc/auth_gss/gss_rpc_upcall.c
> +++ b/net/sunrpc/auth_gss/gss_rpc_upcall.c
> @@ -223,7 +223,7 @@ static int gssp_alloc_receive_pages(struct gssx_arg_accept_sec_context *arg)
>
> static char *gssp_stringify(struct xdr_netobj *netobj)
> {
> - return kstrndup(netobj->data, netobj->len, GFP_KERNEL);
> + return kmemdup_nul(netobj->data, netobj->len, GFP_KERNEL);
> }
>
> static void gssp_hostbased_service(char **principal)
> --
> 2.20.1

\
 
 \ /
  Last update: 2020-06-08 17:26    [W:0.041 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site