lkml.org 
[lkml]   [2020]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next 0/3] s390: use scnprintf() in show() methods
On Sat, May 09, 2020 at 04:56:05PM +0800, Chen Zhou wrote:
> snprintf() returns the number of bytes that would be written,
> which may be greater than the the actual length to be written.
>
> show() methods should return the number of bytes printed into the
> buffer. This is the return value of scnprintf().
>
> Chen Zhou (3):
> s390/crypto: use scnprintf() instead of snprintf()
> s390: use scnprintf() in sys_##_prefix##_##_name##_show
> s390/protvirt: use scnprintf() instead of snprintf()
>
> arch/s390/crypto/prng.c | 14 +++++++-------
> arch/s390/kernel/ipl.c | 2 +-
> arch/s390/kernel/uv.c | 8 ++++----
> 3 files changed, 12 insertions(+), 12 deletions(-)

All applied, even though the buffer has a size of 4k in all cases.
So this doesn't fix anything; but it doesn't hurt as well.

\
 
 \ /
  Last update: 2020-06-08 16:29    [W:0.134 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site