lkml.org 
[lkml]   [2020]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 2/2] phy: intel: Add Keem Bay eMMC PHY support
Date


> -----Original Message-----
> From: Shevchenko, Andriy <andriy.shevchenko@intel.com>
> Sent: Monday, June 8, 2020 6:08 PM
> To: Wan Mohamad, Wan Ahmad Zainie
> <wan.ahmad.zainie.wan.mohamad@intel.com>
> Cc: kishon@ti.com; vkoul@kernel.org; robh+dt@kernel.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; Hunter, Adrian
> <adrian.hunter@intel.com>
> Subject: Re: [PATCH v3 2/2] phy: intel: Add Keem Bay eMMC PHY support
>
> On Mon, Jun 08, 2020 at 04:15:01PM +0800, Wan Ahmad Zainie wrote:
> > Add support for eMMC PHY on Intel Keem Bay SoC.
>
> I think I commented on something already.

I don't recall any. May be on other similar patches.
I will wait for few days before sending next revision, if it is okay with you.

>
> ...
>
> > + if (ret) {
> > + dev_err(&phy->dev, "dllrdy failed, ret=%d\n", ret);
>
> > + return ret;
> > + }
> > +
> > + return 0;
>
> return ret;

I will change in next revision.

>
> ...
>
> > + if (IS_ERR(priv->emmcclk)) {
> > + dev_err(&phy->dev, "ERROR: getting emmcclk\n");
>
> > + return PTR_ERR(priv->emmcclk);
> > + }
> > +
> > + return 0;
>
> return PTR_ERR_OR_ZERO(...);

To clarify, I should replace the block above with,
return PTR_ERR_OR_ZERO(priv->emmcclk);

>
> ...
>
> > + priv->syscfg = devm_regmap_init_mmio(dev, base,
> > + &keembay_regmap_config);
>
> One line.

I will change in next revision.

>
> --
> With Best Regards,
> Andy Shevchenko
>

\
 
 \ /
  Last update: 2020-06-08 12:38    [W:2.205 / U:2.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site