Messages in this thread | | | Subject | Re: [PATCH] mptcp: bugfix for RM_ADDR option parsing | From | Matthieu Baerts <> | Date | Mon, 8 Jun 2020 12:10:23 +0200 |
| |
Hi Geliang,
On 08/06/2020 09:48, Geliang Tang wrote: > In MPTCPOPT_RM_ADDR option parsing, the pointer "ptr" pointed to the > "Subtype" octet, the pointer "ptr+1" pointed to the "Address ID" octet: > > +-------+-------+---------------+ > |Subtype|(resvd)| Address ID | > +-------+-------+---------------+ > | | > ptr ptr+1 > > We should set mp_opt->rm_id to the value of "ptr+1", not "ptr". This patch > will fix this bug.
Thank you for the patch, good catch! Indeed "ptr" should be incremented.
Because this is a bug-fix for net, may you clearly indicate that in the subject to help -net maintainers please? [PATCH net v2]
Also, may you add a "Fixes" tag as well as it is for -net ? I guess it should be:
Fixes: 3df523ab582c ("mptcp: Add ADD_ADDR handling")
The rest is good!
Cheers, Matt -- Matthieu Baerts | R&D Engineer matthieu.baerts@tessares.net Tessares SA | Hybrid Access Solutions www.tessares.net 1 Avenue Jean Monnet, 1348 Louvain-la-Neuve, Belgium
| |