Messages in this thread | | | From | Amit Cohen <> | Subject | RE: [RFC PATCH net-next 04/10] ethtool: Add link extended state | Date | Mon, 8 Jun 2020 10:03:01 +0000 |
| |
Andrew Lunn <andrew@lunn.ch> writes:
>> +/** >> + * enum ethtool_ext_substate_cable_issue - more information in >> + * addition to ETHTOOL_EXT_STATE_CABLE_ISSUE. >> + */ >> +enum ethtool_ext_substate_cable_issue { >> + ETHTOOL_EXT_SUBSTATE_UNSUPPORTED_CABLE = 1, >> + ETHTOOL_EXT_SUBSTATE_SHORTED_CABLE, >> +}; > >I'm not too happy about shorted cable. I can see this getting extended to open cable, shorted to another pair, etc. It then becomes a duplicate of the PHY cable testing infrastructure. A more generic > >> + ETHTOOL_EXT_SUBSTATE_CABLE_TEST_FAILURE, > >would be better, and then the user can use then use the cable testing infrastructure to get the full details. >
Ok, makes sense.
> Andrew
| |