Messages in this thread | | | From | Amit Cohen <> | Subject | RE: [RFC PATCH net-next 05/10] Documentation: networking: ethtool-netlink: Add link extended state | Date | Mon, 8 Jun 2020 10:02:04 +0000 |
| |
Andrew Lunn <andrew@lunn.ch> writes:
>> +Link extended states: >> + >> + ============================ ============================================= >> + ``Autoneg failure`` Failure during auto negotiation mechanism > >I think you need to define 'failure' here. > >Linux PHYs don't have this state. auto-neg is either ongoing, or has completed. There is no time limit for auto-neg. If there is no link partner, auto-neg does not fail, it just continues until there is a link partner which responds and negotiation completes. > >Looking at the state diagrams in 802.3 clause 28, what do you consider as failure? >
Ok, you're right. What about renaming this state to "Autoneg issue" and then as ext_substate you can use something like "Autoneg ongoing"?
> Andrew
| |