lkml.org 
[lkml]   [2020]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.7 034/274] libperf evlist: Fix a refcount leak
    Date
    From: Ian Rogers <irogers@google.com>

    [ Upstream commit 4599d292128d89e4cf866a0ea9a9b047a2de8418 ]

    Memory leaks found by applying LLVM's libfuzzer on the tools/perf
    parse_events function.

    Signed-off-by: Ian Rogers <irogers@google.com>
    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Leo Yan <leo.yan@linaro.org>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: clang-built-linux@googlegroups.com
    Link: http://lore.kernel.org/lkml/20200319023101.82458-2-irogers@google.com
    [ Did a minor adjustment due to some other previous patch having already set evlist->all_cpus to NULL at perf_evlist__exit() ]
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/lib/perf/evlist.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/tools/lib/perf/evlist.c b/tools/lib/perf/evlist.c
    index 5b9f2ca50591..62130d28652d 100644
    --- a/tools/lib/perf/evlist.c
    +++ b/tools/lib/perf/evlist.c
    @@ -125,6 +125,7 @@ static void perf_evlist__purge(struct perf_evlist *evlist)
    void perf_evlist__exit(struct perf_evlist *evlist)
    {
    perf_cpu_map__put(evlist->cpus);
    + perf_cpu_map__put(evlist->all_cpus);
    perf_thread_map__put(evlist->threads);
    evlist->cpus = NULL;
    evlist->threads = NULL;
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-09 03:08    [W:4.029 / U:0.888 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site