lkml.org 
[lkml]   [2020]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.7 131/274] selftests/bpf: Fix memory leak in extract_build_id()
    Date
    From: Andrii Nakryiko <andriin@fb.com>

    [ Upstream commit 9f56bb531a809ecaa7f0ddca61d2cf3adc1cb81a ]

    getline() allocates string, which has to be freed.

    Fixes: 81f77fd0deeb ("bpf: add selftest for stackmap with BPF_F_STACK_BUILD_ID")
    Signed-off-by: Andrii Nakryiko <andriin@fb.com>
    Signed-off-by: Alexei Starovoitov <ast@kernel.org>
    Cc: Song Liu <songliubraving@fb.com>
    Link: https://lore.kernel.org/bpf/20200429012111.277390-7-andriin@fb.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/bpf/test_progs.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/tools/testing/selftests/bpf/test_progs.c b/tools/testing/selftests/bpf/test_progs.c
    index 86d0020c9eec..93970ec1c9e9 100644
    --- a/tools/testing/selftests/bpf/test_progs.c
    +++ b/tools/testing/selftests/bpf/test_progs.c
    @@ -351,6 +351,7 @@ int extract_build_id(char *build_id, size_t size)
    len = size;
    memcpy(build_id, line, len);
    build_id[len] = '\0';
    + free(line);
    return 0;
    err:
    fclose(fp);
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-09 02:57    [W:5.603 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site