lkml.org 
[lkml]   [2020]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.6 031/606] Make the "Reducing compressed framebufer size" message be DRM_INFO_ONCE()
    Date
    From: Peter Jones <pjones@redhat.com>

    commit 82152d424b6cb6fc1ede7d03d69c04e786688740 upstream.

    This was sort of annoying me:

    random:~$ dmesg | tail -1
    [523884.039227] [drm] Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.
    random:~$ dmesg | grep -c "Reducing the compressed"
    47

    This patch makes it DRM_INFO_ONCE() just like the similar message
    farther down in that function is pr_info_once().

    Cc: stable@vger.kernel.org
    Signed-off-by: Peter Jones <pjones@redhat.com>
    Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
    Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1745
    Link: https://patchwork.freedesktop.org/patch/msgid/20180706190424.29194-1-pjones@redhat.com
    [vsyrjala: Rebase due to per-device logging]
    Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
    (cherry picked from commit 6b7fc6a3e6af4ff5773949d0fed70d8e7f68d5ce)
    [Rodrigo: port back to DRM_INFO_ONCE]
    Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/i915/display/intel_fbc.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
    index a1048ece541e..b6d5e7defa5b 100644
    --- a/drivers/gpu/drm/i915/display/intel_fbc.c
    +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
    @@ -478,8 +478,7 @@ static int intel_fbc_alloc_cfb(struct drm_i915_private *dev_priv,
    if (!ret)
    goto err_llb;
    else if (ret > 1) {
    - DRM_INFO("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
    -
    + DRM_INFO_ONCE("Reducing the compressed framebuffer size. This may lead to less power savings than a non-reduced-size. Try to increase stolen memory size if available in BIOS.\n");
    }

    fbc->threshold = ret;
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-09 02:41    [W:4.133 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site