lkml.org 
[lkml]   [2020]   [Jun]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.6 229/606] net/mlx5e: kTLS, Destroy key object after destroying the TIS
    Date
    From: Tariq Toukan <tariqt@mellanox.com>

    [ Upstream commit 16736e11f43b80a38f98f6add54fab3b8c297df3 ]

    The TLS TIS object contains the dek/key ID.
    By destroying the key first, the TIS would contain an invalid
    non-existing key ID.
    Reverse the destroy order, this also acheives the desired assymetry
    between the destroy and the create flows.

    Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support")
    Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
    Reviewed-by: Boris Pismenny <borisp@mellanox.com>
    Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c
    index 46725cd743a3..7d1985fa0d4f 100644
    --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c
    +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c
    @@ -69,8 +69,8 @@ static void mlx5e_ktls_del(struct net_device *netdev,
    struct mlx5e_ktls_offload_context_tx *tx_priv =
    mlx5e_get_ktls_tx_priv_ctx(tls_ctx);

    - mlx5_ktls_destroy_key(priv->mdev, tx_priv->key_id);
    mlx5e_destroy_tis(priv->mdev, tx_priv->tisn);
    + mlx5_ktls_destroy_key(priv->mdev, tx_priv->key_id);
    kvfree(tx_priv);
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-09 01:21    [W:5.596 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site