Messages in this thread | | | From | Navid Emamdoost <> | Date | Sun, 7 Jun 2020 22:47:47 -0500 | Subject | Re: [PATCH] io: pressure: zpa2326: handle pm_runtime_get_sync failure |
| |
On Sat, Jun 6, 2020 at 2:29 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > > > On Saturday, June 6, 2020, Jonathan Cameron <jic23@kernel.org> wrote: >> >> On Thu, 4 Jun 2020 21:44:44 -0500 >> Navid Emamdoost <navid.emamdoost@gmail.com> wrote: >> >> > Calling pm_runtime_get_sync increments the counter even in case of >> > failure, causing incorrect ref count. Call pm_runtime_put if >> > pm_runtime_get_sync fails. >> > >> > Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> >> >> Hi Navid, >> >> This looks to be a fix, be it for a case that we are hopefully >> unlikely to ever hit. Please could you add an appropriate >> Fixes tag so we can work out how far to backport it? >> >> Patch looks good to me so if you just reply with a suitable >> tag I can add it whilst applying.
Hi Jonathan, Here is the fixes tag:
Fixes: 03b262f2bbf4 ("iio:pressure: initial zpa2326 barometer support")
> > > > Should not be "iio: ..." in the prefix?
Yes! It should be "iio" in the patch name.
>> >> >> Thanks, >> >> Jonathan >> >> > --- >> > drivers/iio/pressure/zpa2326.c | 4 +++- >> > 1 file changed, 3 insertions(+), 1 deletion(-) >> > >> > diff --git a/drivers/iio/pressure/zpa2326.c b/drivers/iio/pressure/zpa2326.c >> > index 99dfe33ee402..245f2e2d412b 100644 >> > --- a/drivers/iio/pressure/zpa2326.c >> > +++ b/drivers/iio/pressure/zpa2326.c >> > @@ -664,8 +664,10 @@ static int zpa2326_resume(const struct iio_dev *indio_dev) >> > int err; >> > >> > err = pm_runtime_get_sync(indio_dev->dev.parent); >> > - if (err < 0) >> > + if (err < 0) { >> > + pm_runtime_put(indio_dev->dev.parent); >> > return err; >> > + } >> > >> > if (err > 0) { >> > /* >> > > > -- > With Best Regards, > Andy Shevchenko > >
-- Navid.
| |