lkml.org 
[lkml]   [2020]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [f2fs-dev] [PATCH 2/2] f2fs: use kfree() to free sbi in f2fs_fill_super()
    From
    Date
    On 2020/6/6 2:15, Denis Efremov wrote:
    > Use kfree() instead of kvfree() to free sbi in
    > f2fs_fill_super() because the memory is allocated with
    > kzalloc() in the function.

    Could you fix them in one patch?

    In addition, we need to fix them in f2fs_put_super() as well.

    Thanks,

    >
    > Fixes: 5222595d093e ("f2fs: use kvmalloc, if kmalloc is failed")
    > Signed-off-by: Denis Efremov <efremov@linux.com>
    > ---
    > fs/f2fs/super.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
    > index 9a3c8eba37e2..39b644c7e9d4 100644
    > --- a/fs/f2fs/super.c
    > +++ b/fs/f2fs/super.c
    > @@ -3812,7 +3812,7 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
    > free_sbi:
    > if (sbi->s_chksum_driver)
    > crypto_free_shash(sbi->s_chksum_driver);
    > - kvfree(sbi);
    > + kfree(sbi);
    >
    > /* give only one another chance */
    > if (retry_cnt > 0 && skip_recovery) {
    >

    \
     
     \ /
      Last update: 2020-06-08 04:52    [W:2.620 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site