lkml.org 
[lkml]   [2020]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 04/39] memory: tegra20-emc: Make driver modular
    Date
    This patch adds modularization support to the Tegra20 EMC driver. Driver
    now can be compiled as a loadable kernel module.

    Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
    ---
    drivers/memory/tegra/Kconfig | 2 +-
    drivers/memory/tegra/tegra20-emc.c | 16 +++++++++++-----
    2 files changed, 12 insertions(+), 6 deletions(-)

    diff --git a/drivers/memory/tegra/Kconfig b/drivers/memory/tegra/Kconfig
    index 9f0a96bf9ccc..7e0e1ef87763 100644
    --- a/drivers/memory/tegra/Kconfig
    +++ b/drivers/memory/tegra/Kconfig
    @@ -8,7 +8,7 @@ config TEGRA_MC
    NVIDIA Tegra SoCs.

    config TEGRA20_EMC
    - bool "NVIDIA Tegra20 External Memory Controller driver"
    + tristate "NVIDIA Tegra20 External Memory Controller driver"
    default y
    depends on ARCH_TEGRA_2x_SOC
    help
    diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
    index 027f46287dbf..035d9251e28a 100644
    --- a/drivers/memory/tegra/tegra20-emc.c
    +++ b/drivers/memory/tegra/tegra20-emc.c
    @@ -724,6 +724,13 @@ static int tegra_emc_probe(struct platform_device *pdev)
    platform_set_drvdata(pdev, emc);
    tegra_emc_debugfs_init(emc);

    + /*
    + * Don't allow the kernel module to be unloaded. Unloading adds some
    + * extra complexity which doesn't really worth the effort in a case of
    + * this driver.
    + */
    + try_module_get(THIS_MODULE);
    +
    return 0;

    unset_cb:
    @@ -736,6 +743,7 @@ static const struct of_device_id tegra_emc_of_match[] = {
    { .compatible = "nvidia,tegra20-emc", },
    {},
    };
    +MODULE_DEVICE_TABLE(of, tegra_emc_of_match);

    static struct platform_driver tegra_emc_driver = {
    .probe = tegra_emc_probe,
    @@ -745,9 +753,7 @@ static struct platform_driver tegra_emc_driver = {
    .suppress_bind_attrs = true,
    },
    };
    +module_platform_driver(tegra_emc_driver);

    -static int __init tegra_emc_init(void)
    -{
    - return platform_driver_register(&tegra_emc_driver);
    -}
    -subsys_initcall(tegra_emc_init);
    +MODULE_DESCRIPTION("NVIDIA Tegra20 EMC driver");
    +MODULE_LICENSE("GPL v2");
    --
    2.26.0
    \
     
     \ /
      Last update: 2020-06-07 20:57    [W:4.032 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site