Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Sun, 7 Jun 2020 19:41:44 +0200 | Subject | Re: [PATCH] ARM: dts: r8a7742-iwg21d-q7-dbcm-ca: Add device tree for camera DB |
| |
Hi Prabhakar,
On Sun, Jun 7, 2020 at 6:19 PM Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote: > On Fri, Jun 5, 2020 at 1:27 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Wed, May 27, 2020 at 3:29 PM Lad Prabhakar > > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > Add support for the camera daughter board which is connected to > > > iWave's RZ/G1H Qseven carrier board. Also enable ttySC[0135] and > > > ethernet1 interfaces. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > > --- /dev/null > > > +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dts > > > > > +&scifb1 { > > > + pinctrl-0 = <&scifb1_pins>; > > > + pinctrl-names = "default"; > > > + status = "okay"; > > > > Before I queue this in renesas-devel for v5.9, I have on question: > > As this port carries RTS/CTS signals, perhaps you want to add > > > > rts-gpios = <&gpio4 21 GPIO_ACTIVE_LOW>; > > cts-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>; > > > Aaha the user manual mentioned RTS/CTS wasn't connected, but I tested > this with the above which disproves the Doc. Shall I post it as a
RTS/CTS are indeed not connected to the dedicated RTS/CTS pins of SCIFB1, so the documentation is right. However, the pins on the serial port connector can be used as GPIOs, hence they can be used with software-controlled RTS/CTS.
> separate patch or post a v2 including it.
Up to you, I can handle both.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |