lkml.org 
[lkml]   [2020]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v9 RESEND 07/13] spi: imx: fix ERR009165
    Date
    Change to XCH  mode even in dma mode, please refer to the below
    errata:
    https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf

    Signed-off-by: Robin Gong <yibin.gong@nxp.com>
    Acked-by: Mark Brown <broonie@kernel.org>
    ---
    drivers/spi/spi-imx.c | 10 +++-------
    1 file changed, 3 insertions(+), 7 deletions(-)

    diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
    index 84aebee..d4fe5dd 100644
    --- a/drivers/spi/spi-imx.c
    +++ b/drivers/spi/spi-imx.c
    @@ -591,8 +591,8 @@ static int mx51_ecspi_prepare_transfer(struct spi_imx_data *spi_imx,
    ctrl |= mx51_ecspi_clkdiv(spi_imx, t->speed_hz, &clk);
    spi_imx->spi_bus_clk = clk;

    - if (spi_imx->usedma)
    - ctrl |= MX51_ECSPI_CTRL_SMC;
    + /* ERR009165: work in XHC mode as PIO */
    + ctrl &= ~MX51_ECSPI_CTRL_SMC;

    writel(ctrl, spi_imx->base + MX51_ECSPI_CTRL);

    @@ -623,7 +623,7 @@ static void mx51_setup_wml(struct spi_imx_data *spi_imx)
    * and enable DMA request.
    */
    writel(MX51_ECSPI_DMA_RX_WML(spi_imx->wml - 1) |
    - MX51_ECSPI_DMA_TX_WML(spi_imx->wml) |
    + MX51_ECSPI_DMA_TX_WML(0) |
    MX51_ECSPI_DMA_RXT_WML(spi_imx->wml) |
    MX51_ECSPI_DMA_TEDEN | MX51_ECSPI_DMA_RXDEN |
    MX51_ECSPI_DMA_RXTDEN, spi_imx->base + MX51_ECSPI_DMA);
    @@ -1273,10 +1273,6 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx,
    {
    int ret;

    - /* use pio mode for i.mx6dl chip TKT238285 */
    - if (of_machine_is_compatible("fsl,imx6dl"))
    - return 0;
    -
    spi_imx->wml = spi_imx->devtype_data->fifo_size / 2;

    /* Prepare for TX DMA: */
    --
    2.7.4
    \
     
     \ /
      Last update: 2020-06-06 17:22    [W:4.124 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site