Messages in this thread | | | Subject | Re: [PATCH net] net: dp83869: Reset return variable if PHY strap is read | From | Florian Fainelli <> | Date | Fri, 5 Jun 2020 14:12:29 -0700 |
| |
On 6/5/2020 1:51 PM, Dan Murphy wrote: > When the PHY's strap register is read to determine if lane swapping is > needed the phy_read_mmd returns the value back into the ret variable. > > If the call to read the strap fails the failed value is returned. If > the call to read the strap is successful then ret is possibly set to a > non-zero positive number. Without reseting the ret value to 0 this will > cause the parse DT function to return a failure. > > Fixes: c4566aec6e808 ("net: phy: dp83869: Update port-mirroring to read straps") > Signed-off-by: Dan Murphy <dmurphy@ti.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |