lkml.org 
[lkml]   [2020]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 05/16] dyndbg: fix overcounting of ram used by dyndbg
    Date
    during dyndbg init, verbose logging prints its ram overhead.  It
    counted strlens of struct _ddebug's 4 string members, in all callsite
    entries, which would be approximately correct if each had been
    mallocd. But they are pointers into shared .rodata; for example, all
    10 kobject callsites have identical filename, module values.

    Its best not to count that memory at all, since we cannot know they
    were linked in because of CONFIG_DYNAMIC_DEBUG=y, and we want to
    report a number that reflects what ram is saved by deconfiguring it.

    Also fix wording and size under-reporting of the __dyndbg section.

    Heres my overhead, on a virtme-run VM on a fedora-31 laptop:

    dynamic_debug:dynamic_debug_init: 260 modules, 2479 entries \
    and 10400 bytes in ddebug tables, 138824 bytes in __dyndbg section

    Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
    ---
    lib/dynamic_debug.c | 8 ++------
    1 file changed, 2 insertions(+), 6 deletions(-)

    diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
    index e17d4e2661d8..25cc1eb86d96 100644
    --- a/lib/dynamic_debug.c
    +++ b/lib/dynamic_debug.c
    @@ -1017,7 +1017,6 @@ static int __init dynamic_debug_init(void)
    char *cmdline;
    int ret = 0;
    int n = 0, entries = 0, modct = 0;
    - int verbose_bytes = 0;

    if (&__start___dyndbg == &__stop___dyndbg) {
    pr_warn("_ddebug table is empty in a CONFIG_DYNAMIC_DEBUG build\n");
    @@ -1028,9 +1027,6 @@ static int __init dynamic_debug_init(void)
    iter_start = iter;
    for (; iter < __stop___dyndbg; iter++) {
    entries++;
    - verbose_bytes += strlen(iter->modname) + strlen(iter->function)
    - + strlen(iter->filename) + strlen(iter->format);
    -
    if (strcmp(modname, iter->modname)) {
    modct++;
    ret = ddebug_add_module(iter_start, n, modname);
    @@ -1047,9 +1043,9 @@ static int __init dynamic_debug_init(void)
    goto out_err;

    ddebug_init_success = 1;
    - vpr_info("%d modules, %d entries and %d bytes in ddebug tables, %d bytes in (readonly) verbose section\n",
    + vpr_info("%d modules, %d entries and %d bytes in ddebug tables, %d bytes in __dyndbg section\n",
    modct, entries, (int)(modct * sizeof(struct ddebug_table)),
    - verbose_bytes + (int)(__stop___dyndbg - __start___dyndbg));
    + (int)(entries * sizeof(struct _ddebug)));

    /* apply ddebug_query boot param, dont unload tables on err */
    if (ddebug_setup_string[0] != '\0') {
    --
    2.26.2
    \
     
     \ /
      Last update: 2020-06-05 18:28    [W:2.773 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site