lkml.org 
[lkml]   [2020]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] crypto: hisilicon - fix strncpy warning with strlcpy
From
Date


On 2020/6/5 下午8:17, Herbert Xu wrote:
> On Fri, Jun 05, 2020 at 05:34:32PM +0800, Zhangfei Gao wrote:
>> Will add a check after the copy.
>>
>>         strlcpy(interface.name, pdev->driver->name, sizeof(interface.name));
>>         if (strlen(pdev->driver->name) != strlen(interface.name))
>>                 return -EINVAL;
> You don't need to do strlen. The function strlcpy returns the
> length of the source string.
>
> Better yet use strscpy which will even return an error for you.
>
>
Yes, good idea, we can use strscpy.

+       int ret;

-       strncpy(interface.name, pdev->driver->name, sizeof(interface.name));
+       ret = strscpy(interface.name, pdev->driver->name,
sizeof(interface.name));
+       if (ret < 0)
+               return ret;

Will resend later, thanks Herbert.


\
 
 \ /
  Last update: 2020-06-05 17:27    [W:0.117 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site