Messages in this thread | | | Date | Fri, 5 Jun 2020 16:20:10 +0200 | From | Jessica Yu <> | Subject | Re: [PATCH v4 11/11] module: Make module_enable_ro() static again |
| |
+++ Guenter Roeck [05/06/20 06:24 -0700]: >On Wed, Apr 29, 2020 at 10:24:53AM -0500, Josh Poimboeuf wrote: >> Now that module_enable_ro() has no more external users, make it static >> again. >> >> Suggested-by: Jessica Yu <jeyu@kernel.org> >> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> >> Acked-by: Miroslav Benes <mbenes@suse.cz> > >Apparently this patch made it into the upstream kernel on its own, >not caring about its dependencies. Results are impressive. > >Build results: > total: 155 pass: 101 fail: 54 >Qemu test results: > total: 431 pass: 197 fail: 234 > >That means bisects will be all but impossible until this is fixed. >Was that really necessary ?
Sigh, I am really sorry about this. We made a mistake in handling inter-tree dependencies between livepatching and modules-next, unfortunately :-( Merging the modules-next pull request next should resolve the module_enable_ro() not defined for !ARCH_HAS_STRICT_MODULE_RWX build issue. The failure was hidden in linux-next since both trees were always merged together. Again, it doesn't excuse us from build testing our separate trees more rigorously.
| |