lkml.org 
[lkml]   [2020]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.6 32/43] HID: sony: Fix for broken buttons on DS3 USB dongles
    Date
    From: Scott Shumate <scott.shumate@gmail.com>

    commit e72455b898ac678667c5674668186b4670d87d11 upstream.

    Fix for non-working buttons on knock-off USB dongles for Sony
    controllers. These USB dongles are used to connect older Sony DA/DS1/DS2
    controllers via USB and are common on Amazon, AliExpress, etc. Without
    the patch, the square, X, and circle buttons do not function. These
    dongles used to work prior to kernel 4.10 but removing the global DS3
    report fixup in commit e19a267b9987 ("HID: sony: DS3 comply to Linux gamepad
    spec") exposed the problem.

    Many people reported the problem on the Ubuntu forums and are working
    around the problem by falling back to the 4.9 hid-sony driver.

    The problem stems from these dongles incorrectly reporting their button
    count as 13 instead of 16. This patch fixes up the report descriptor by
    changing the button report count to 16 and removing 3 padding bits.

    Cc: stable@vger.kernel.org
    Fixes: e19a267b9987 ("HID: sony: DS3 comply to Linux gamepad spec")
    Signed-off-by: Scott Shumate <scott.shumate@gmail.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/hid/hid-sony.c | 17 +++++++++++++++++
    1 file changed, 17 insertions(+)

    --- a/drivers/hid/hid-sony.c
    +++ b/drivers/hid/hid-sony.c
    @@ -867,6 +867,23 @@ static u8 *sony_report_fixup(struct hid_
    if (sc->quirks & PS3REMOTE)
    return ps3remote_fixup(hdev, rdesc, rsize);

    + /*
    + * Some knock-off USB dongles incorrectly report their button count
    + * as 13 instead of 16 causing three non-functional buttons.
    + */
    + if ((sc->quirks & SIXAXIS_CONTROLLER_USB) && *rsize >= 45 &&
    + /* Report Count (13) */
    + rdesc[23] == 0x95 && rdesc[24] == 0x0D &&
    + /* Usage Maximum (13) */
    + rdesc[37] == 0x29 && rdesc[38] == 0x0D &&
    + /* Report Count (3) */
    + rdesc[43] == 0x95 && rdesc[44] == 0x03) {
    + hid_info(hdev, "Fixing up USB dongle report descriptor\n");
    + rdesc[24] = 0x10;
    + rdesc[38] = 0x10;
    + rdesc[44] = 0x00;
    + }
    +
    return rdesc;
    }


    \
     
     \ /
      Last update: 2020-06-05 16:18    [W:4.075 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site