Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH 04/10] rtlwifi: rtl8192cu: Remove uninitialized_var() usage | Date | Fri, 05 Jun 2020 12:18:22 +0300 |
| |
Kees Cook <keescook@chromium.org> writes:
> Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings (e.g. > "unused variable"). If the compiler thinks it is uninitialized, either > simply initialize the variable or make compiler changes. As a precursor > to removing[2] this[3] macro[4], just initialize this variable to NULL, > and avoid sending garbage by returning. > > [1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/ > [2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/ > [3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/ > [4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/ > > Signed-off-by: Kees Cook <keescook@chromium.org>
To which tree should this go? If something else than wireless-drivers tree:
Acked-by: Kalle Valo <kvalo@codeaurora.org>
But let me know if you want me to take this.
-- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |