lkml.org 
[lkml]   [2020]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/3] Relocate execve() sanity checks
On Fri, Jun 05, 2020 at 05:40:53PM -0700, Andrew Morton wrote:
> On Fri, 5 Jun 2020 09:00:10 -0700 Kees Cook <keescook@chromium.org> wrote:
>
> > While looking at the code paths for the proposed O_MAYEXEC flag, I saw
> > some things that looked like they should be fixed up.
> >
> > exec: Change uselib(2) IS_SREG() failure to EACCES
> > This just regularizes the return code on uselib(2).
> >
> > exec: Move S_ISREG() check earlier
> > This moves the S_ISREG() check even earlier than it was already.
> >
> > exec: Move path_noexec() check earlier
> > This adds the path_noexec() check to the same place as the
> > S_ISREG() check.
>
> Thanks.
>
> These don't seem super-urgent and they aren't super-reviewed, so I
> suggest we hold them off until the next cycle?

Agreed; that's fine by me. It's mostly clean up and preparation for
performing future checking through the MAY_EXEC path.

And I'd love to get an Ack from Al or Aleksa, nudge nudge. :)

--
Kees Cook

\
 
 \ /
  Last update: 2020-06-06 03:46    [W:0.062 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site