Messages in this thread | | | From | Linus Torvalds <> | Date | Thu, 4 Jun 2020 14:12:14 -0700 | Subject | Re: [PATCH] mm/vmalloc: track which page-table levels were modified |
| |
On Thu, Jun 4, 2020 at 2:06 PM Andrew Morton <akpm@linux-foundation.org> wrote: > > As discussed over in > https://lore.kernel.org/linux-mm/20200604164814.GA7600@kernel.org/, > Mike's "mm: remove __ARCH_HAS_5LEVEL_HACK" patchset > (http://lkml.kernel.org/r/20200414153455.21744-1-rppt@kernel.org) is > expected to fix this. 5level-fixup.h gets removed.
Ok, even better.
That said, the commentary about "why is p.._alloc_track() in such a core header file, when it's only used by two special cases" is probably still true regardless of the 5-level fixup header.. I assume Mike didn't do those kinds of changes?
Yeah, I'm probably flailing at windmills, but I do dislike how we often end up just growing the very core headers that get included by everybody without ever trying to fix that uncontrolled growth..
Linus
| |