Messages in this thread | | | Subject | Re: [PATCH bpf v2] bpf: fix unused-var without NETDEVICES | From | Daniel Borkmann <> | Date | Thu, 4 Jun 2020 22:53:37 +0200 |
| |
On 6/3/20 10:45 PM, Song Liu wrote: > On Wed, Jun 3, 2020 at 12:05 PM Matthieu Baerts > <matthieu.baerts@tessares.net> wrote: >> >> A recent commit added new variables only used if CONFIG_NETDEVICES is >> set. A simple fix would be to only declare these variables if the same >> condition is valid but Alexei suggested an even simpler solution: >> >> since CONFIG_NETDEVICES doesn't change anything in .h I think the >> best is to remove #ifdef CONFIG_NETDEVICES from net/core/filter.c >> and rely on sock_bindtoindex() returning ENOPROTOOPT in the extreme >> case of oddly configured kernels. >> >> Fixes: 70c58997c1e8 ("bpf: Allow SO_BINDTODEVICE opt in bpf_setsockopt") >> Suggested-by: Alexei Starovoitov <alexei.starovoitov@gmail.com> >> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net> > > Acked-by: Song Liu <songliubraving@fb.com>
Applied, thanks!
| |