lkml.org 
[lkml]   [2020]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] pinctrl: tegra: Use noirq suspend/resume callbacks
From
Date
04.06.2020 20:49, Vidya Sagar пишет:
> Use noirq suspend/resume callbacks as other drivers which implement
> noirq suspend/resume callbacks (Ex:- PCIe) depend on pinctrl driver to
> configure the signals used by their respective devices in the noirq phase.
>
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> drivers/pinctrl/tegra/pinctrl-tegra.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
> index 21661f6490d6..195cfe557511 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra.c
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
> @@ -731,8 +731,8 @@ static int tegra_pinctrl_resume(struct device *dev)
> }
>
> const struct dev_pm_ops tegra_pinctrl_pm = {
> - .suspend = &tegra_pinctrl_suspend,
> - .resume = &tegra_pinctrl_resume
> + .suspend_noirq = &tegra_pinctrl_suspend,
> + .resume_noirq = &tegra_pinctrl_resume
> };
>
> static bool tegra_pinctrl_gpio_node_has_range(struct tegra_pmx *pmx)
>

That's a good catch! Perhaps I2C on later Tegra SoCs also should suffer
similarly to the PCIe.

Reviewed-by: Dmitry Osipenko <digetx@gmail.com>

\
 
 \ /
  Last update: 2020-06-04 20:00    [W:0.846 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site