Messages in this thread | | | Date | Thu, 4 Jun 2020 06:17:32 +0200 | From | Lukas Wunner <> | Subject | Re: [PATCH 3/3] spi: bcm2835: Enable shared interrupt support |
| |
On Wed, Jun 03, 2020 at 08:46:55PM -0700, Florian Fainelli wrote: > +static const struct of_device_id bcm2835_spi_match[] = { > + { .compatible = "brcm,bcm2835-spi", .data = &bcm2835_spi_interrupt }, > + { .compatible = "brcm,bcm2711-spi", .data = &bcm2835_spi_sh_interrupt }, > + { .compatible = "brcm,bcm7211-spi", .data = &bcm2835_spi_sh_interrupt }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, bcm2835_spi_match);
Maybe I'm missing something but I think you either have to reverse the order of the entries in this array or change patch [2/3] to drop "brcm,bcm2835-spi" from the compatible string:
__of_match_node() iterates over the entries in the array above and calls __of_device_is_compatible() for each of them, which returns success if the entry matches any of the device's compatible string.
Because "brcm,bcm2835-spi" is checked first and that string is present on the controllers with shared interrupt, they're all deemed not to use shared interrupts.
If you opt so fix this by dropping "brcm,bcm2835-spi" from the device's compatible strings, then you have to move patch [2/3] behind patch [3/3].
> static int bcm2835_spi_probe(struct platform_device *pdev) > { > + irqreturn_t (*bcm2835_spi_isr_func)(int, void *);
A more succinct alternative is:
irq_handler_t bcm2835_spi_isr_func;
Otherwise this patch LGTM.
Thanks,
Lukas
| |