lkml.org 
[lkml]   [2020]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC 2/4] regulator: lp87565: dt: remove duplicated section
    On Wed, 03 Jun 2020, Luca Ceresoli wrote:

    > The "Required properties:" section is copied verbatim for each of the two
    > supported chips. In preparation to add a new chip variant make it a common
    > section and keep the two examples to differentiate between the two chips.
    >
    > Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
    > ---
    > .../devicetree/bindings/mfd/lp87565.txt | 21 ++++---------------
    > 1 file changed, 4 insertions(+), 17 deletions(-)
    >
    > diff --git a/Documentation/devicetree/bindings/mfd/lp87565.txt b/Documentation/devicetree/bindings/mfd/lp87565.txt
    > index 41671e0dc26b..b75ae23a1ef3 100644
    > --- a/Documentation/devicetree/bindings/mfd/lp87565.txt
    > +++ b/Documentation/devicetree/bindings/mfd/lp87565.txt
    > @@ -1,7 +1,7 @@
    > TI LP87565 PMIC MFD driver
    >
    > Required properties:
    > - - compatible: "ti,lp87565", "ti,lp87565-q1"
    > + - compatible: one of "ti,lp87565", "ti,lp87565-q1", "ti,lp87561-q1"

    What happened to your tabbing here?

    All the other entries start with a capital letter. So should this.

    > - reg: I2C slave address.
    > - gpio-controller: Marks the device node as a GPIO Controller.
    > - #gpio-cells: Should be two. The first cell is the pin number and
    > @@ -10,7 +10,8 @@ Required properties:
    > - xxx-in-supply: Phandle to parent supply node of each regulator
    > populated under regulators node. xxx should match
    > the supply_name populated in driver.
    > -Example:
    > +
    > +Example for the TI LP87565-Q1 PMIC (dual 2-phase output configuration):
    >
    > lp87565_pmic: pmic@60 {
    > compatible = "ti,lp87565-q1";
    > @@ -42,21 +43,7 @@ lp87565_pmic: pmic@60 {
    > };
    > };
    >
    > -TI LP87561 PMIC:
    > -
    > -This is a single output 4-phase regulator configuration
    > -
    > -Required properties:
    > - - compatible: "ti,lp87561-q1"
    > - - reg: I2C slave address.
    > - - gpio-controller: Marks the device node as a GPIO Controller.
    > - - #gpio-cells: Should be two. The first cell is the pin number and
    > - the second cell is used to specify flags.
    > - See ../gpio/gpio.txt for more information.
    > - - xxx-in-supply: Phandle to parent supply node of each regulator
    > - populated under regulators node. xxx should match
    > - the supply_name populated in driver.
    > -Example:
    > +Example for the TI LP87561 PMIC (single 4-phase output configuration):
    >
    > lp87561_pmic: pmic@62 {
    > compatible = "ti,lp87561-q1";

    --
    Lee Jones [李琼斯]
    Linaro Services Technical Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog

    \
     
     \ /
      Last update: 2020-06-04 08:47    [W:4.344 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site