Messages in this thread | | | Subject | Re: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format | From | James Smart <> | Date | Thu, 4 Jun 2020 08:20:18 -0700 |
| |
On 5/25/2020 9:21 PM, Dongli Zhang wrote: > The nvme host and target verify the wwnn and wwpn format via > nvme_fc_parse_traddr(). For instance, it is required that the length of > wwnn to be either 21 ("nn-0x") or 19 (nn-). > > Add this verification to nvme-fcloop so that the input should always be in > hex and the length of input should always be 18. > > Otherwise, the user may use e.g. 0x2 to create fcloop local port, while > 0x0000000000000002 is required for nvme host and target. This makes the > requirement of format confusing. > > Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com> > --- > drivers/nvme/target/fcloop.c | 29 +++++++++++++++++++++++------ > 1 file changed, 23 insertions(+), 6 deletions(-) > >
Reviewed-by: James Smart <james.smart@broadcom.com>
Looks good. Sorry for the delay.
-- james
| |