lkml.org 
[lkml]   [2020]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] rcu: Stop shrinker loop
On Thu, Jun 04, 2020 at 12:23:20PM +0200, Peter Enderborg wrote:
> The count and scan can be separated in time. It is a fair chance
> that all work is already done when the scan starts. It
> then might retry. This is can be avoided with returning SHRINK_STOP.
>
> Signed-off-by: Peter Enderborg <peter.enderborg@sony.com>
> ---
> kernel/rcu/tree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index c716eadc7617..8b36c6b2887d 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -3310,7 +3310,7 @@ kfree_rcu_shrink_scan(struct shrinker *shrink, struct shrink_control *sc)
> break;
> }
>
> - return freed;
> + return freed == 0 ? SHRINK_STOP : freed;
> }
>
The loop will be stopped anyway sooner or later, but sooner is better :)
To me that change makes sense.

Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>

--
Vlad Rezki

\
 
 \ /
  Last update: 2020-06-04 15:43    [W:5.413 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site