Messages in this thread | | | From | Dmitry Vyukov <> | Date | Thu, 4 Jun 2020 15:07:11 +0200 | Subject | Re: [PATCH v4 4/7] kcov: move t->kcov_sequence assignment |
| |
On Thu, Mar 26, 2020 at 3:44 PM Andrey Konovalov <andreyknvl@google.com> wrote: > > Move t->kcov_sequence assignment before assigning t->kcov_mode > for consistency. > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
> --- > kernel/kcov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/kcov.c b/kernel/kcov.c > index 888d0a236b04..b985b7a72870 100644 > --- a/kernel/kcov.c > +++ b/kernel/kcov.c > @@ -318,10 +318,10 @@ static void kcov_start(struct task_struct *t, struct kcov *kcov, > /* Cache in task struct for performance. */ > t->kcov_size = size; > t->kcov_area = area; > + t->kcov_sequence = sequence; > /* See comment in check_kcov_mode(). */ > barrier(); > WRITE_ONCE(t->kcov_mode, mode); > - t->kcov_sequence = sequence; > } > > static void kcov_stop(struct task_struct *t) > -- > 2.26.0.rc2.310.g2932bb562d-goog >
| |