Messages in this thread | | | From | Michael Kelley <> | Subject | RE: [PATCH v3 2/3] scsi: storvsc: Use vmbus_requestor to generate transaction IDs for VMBus hardening | Date | Tue, 30 Jun 2020 18:37:03 +0000 |
| |
From: Andres Beltran <lkmlabelt@gmail.com> Sent: Tuesday, June 30, 2020 8:32 AM > > Currently, pointers to guest memory are passed to Hyper-V as > transaction IDs in storvsc. In the face of errors or malicious > behavior in Hyper-V, storvsc should not expose or trust the transaction > IDs returned by Hyper-V to be valid guest memory addresses. Instead, > use small integers generated by vmbus_requestor as requests > (transaction) IDs. > > Cc: "James E.J. Bottomley" <jejb@linux.ibm.com> > Cc: "Martin K. Petersen" <martin.petersen@oracle.com> > Cc: linux-scsi@vger.kernel.org > Signed-off-by: Andres Beltran <lkmlabelt@gmail.com> > --- > Changes in v2: > - Add casts to unsigned long to fix warnings on 32bit. > > drivers/scsi/storvsc_drv.c | 85 +++++++++++++++++++++++++++++++++----- > 1 file changed, 74 insertions(+), 11 deletions(-) >
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
| |